generated from cheqd/.github
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support date only format with versionTime, resourceTime query parameters [DEV-2807] #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formats of date in versionTime and resourceVersionTime queries.
query parameter.
resourceVersionTime query.
abdulla-ashurov
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
test
Add/improve unit & integration tests
labels
Jun 18, 2023
abdulla-ashurov
removed
the
documentation
Improvements or additions to documentation
label
Jun 18, 2023
- Layout - ANSIC - UnixDate - RubyDate - RFC822 - RFC822Z - RFC850 - RFC1123 - RFC1123Z
different date formats.
resourceVersionTime query with different date formats.
versionTime and resourceVersionTime queries with an invalid date format.
lampkin-diet
approved these changes
Jun 20, 2023
lampkin-diet
pushed a commit
that referenced
this pull request
Jun 20, 2023
… and parsing (#169) * feat: Support date only format with versionTime, resourceTime query parameters [DEV-2807] (#165) * Add implementation for supporting different formats of date in versionTime and resourceVersionTime queries. * Add positive integration tests for versionTime query parameter. * Remove unused date formats. * Refactor code. * Update positive version time integration tests. * Update integration test. * Add positive integration tests for testing resourceVersionTime query. * Update Makefile. * Add implementation for supporting more date types: - Layout - ANSIC - UnixDate - RubyDate - RFC822 - RFC822Z - RFC850 - RFC1123 - RFC1123Z * Add more positive integration test for testing different date formats. * Refactor code. * Add positive integration tests for testing resourceVersionTime query with different date formats. * Add negative integration tests for testing versionTime and resourceVersionTime queries with an invalid date format. * Use constants variables instead of magic strings. * Update golang version in Dockerfile. * Bump golang version from v1.18 to v1.20 in go.mod. * fix: Minor fix of "transformKey" to "transformKeys" [DEV-2813] (#164) * Rename "transformKey" to "transformKeys". * Update swagger OpenAPI. * fix: Fix codeql (#170) fix: Move codeql to using go.mod file also --------- Co-authored-by: abdulla-ashurov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionTime
andresourceVersionTime
queries:01/02 03:04:05PM '06 -0700
Mon Jan _2 15:04:05 2006
Mon Jan _2 15:04:05 MST 2006
Mon Jan 02 15:04:05 -0700 2006
02 Jan 06 15:04 MST
02 Jan 06 15:04 -0700
Monday, 02-Jan-06 15:04:05 MST
Mon, 02 Jan 2006 15:04:05 MST
Mon, 02 Jan 2006 15:04:05 -0700
2006-01-02T15:04:05Z07:00
2006-01-02T15:04:05.999999999Z07:00
2006-01-02 15:04:05
2006-01-02
versionTime
andresourceVersionTime
queries with new date formats.